Domain settings: Yosemite layer changes for 2 actions #8601
+116
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…main-settings-yosemite * feat/8558-domain-settings-networking: Fix build errors. # Conflicts: # Yosemite/Yosemite/Stores/PaymentStore.swift # Yosemite/YosemiteTests/Mocks/Networking/Remote/MockDomainRemote.swift # Yosemite/YosemiteTests/Mocks/Networking/Remote/MockPaymentRemote.swift
Collaborator
You can test the changes from this Pull Request by:
|
Base automatically changed from
feat/8558-domain-settings-networking
to
trunk
January 10, 2023 05:54
selanthiraiyan
approved these changes
Jan 10, 2023
Contributor
selanthiraiyan
left a comment
selanthiraiyan
left a comment
There was a problem hiding this comment.
This works as described in the testing instructions. 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8558
Based on #8600
Description
Why
After the user creates a store, they might want to choose a proper domain for their new store. The domain settings screen shows the domains of a WPCOM site, and allows the merchant to add a domain either using their domain credit or the checkout flow similar to the Jetpack app.
Networking layer changes
More technical details at the spike: pe5sF9-Ug-p2
This PR just contains the Yosemite layer changes for two actions required to show the domain settings UI:
DomainAction.loadDomains: this loads the site's domains, including the free staging domainPaymentAction.loadSiteCurrentPlan: this loads the site's WPCOM plans, and returns the current plan to determine if the site has domain credit so that the user can pick a domain for free (available from certain WPCOM plans)Testing instructions
Prerequisite: a WC store with a WPCOM plan is required
Domainrow under the store settings sectionDomainrow --> a modal should be shown with a free staging domain at the top with the actual site domain. most likely the site also has a*.wordpress.comdomain, so the bottom CTA isn't shown for nowScreenshots
RELEASE-NOTES.txtif necessary.